Support RocksDB 7.x BackupEngineOptions #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aleksuss, @stanislav-tkach, could you help to review this PR? |
aleksuss
requested review from
stanislav-tkach and
aleksuss
and removed request for
stanislav-tkach
exabytes18
force-pushed
the
support-rocksdb-7.x-backup-engine-options
branch
from
cde4d66
to
5efce4b
Compare
|
@aleksuss, I've fixed a clippy warning. Could you approve the workflow run again? |
BusyJay
pushed a commit
to BusyJay/rust-rocksdb
that referenced
this pull request
Dec 10, 2022
Signed-off-by: Wenbo Zhang <ethercflow@gmail.com>
exabytes18
force-pushed
the
support-rocksdb-7.x-backup-engine-options
branch
from
5efce4b
to
1827aea
Compare
|
@aleksuss, could you take a look at the PR when you next have a chance? |
stanislav-tkach
approved these changes
Dec 26, 2022
exabytes18
force-pushed
the
support-rocksdb-7.x-backup-engine-options
branch
from
1827aea
to
5fee0c0
Compare
|
@aleksuss, @stanislav-tkach, could you help to merge this? |
exabytes18
force-pushed
the
support-rocksdb-7.x-backup-engine-options
branch
from
5fee0c0
to
afff50d
Compare
aleksuss
reviewed
Jan 25, 2023
| @@ -217,27 +224,40 @@ impl BackupEngine { | |||
| } | |||
|
|
|||
| impl BackupEngineOptions { | |||
| // | |||
| } | |||
| pub fn new<P: AsRef<Path>>(backup_dir: P) -> Result<Self, Error> { | |||
There was a problem hiding this comment.
Please, add some description to the public methods.
There was a problem hiding this comment.
Done. Please have another look.
exabytes18
force-pushed
the
support-rocksdb-7.x-backup-engine-options
branch
from
526105d
to
72ce11d
Compare
aleksuss
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main objective of this PR is to support
rocksdb_backup_engine_options_t(introduced in facebook/rocksdb@78aee6f) so that we can call the associatedrocksdb_backup_engine_options_set_max_background_operationsfunction and achieve higher parallelism for backup and restore operations (notably, the current parallelism is 1, meaning that rocksdb will only copy/checksum/hardlink/whatever 1 file at a time, which is insufficient for rocksdb to full utilize hardware on even modest machines).One side-effect of this PR is that the signature for BackupEngine::open changes from
open<P: AsRef<Path>>(opts: &BackupEngineOptions, path: P)toopen(opts: &BackupEngineOptions, env: &Env). This may cause some consumer code to fail to compile, but it aligns better with the RocksDB-properBackupEngine::Open()signature, so I believe it's a worthwhile change.Finally, I'm not well-versed in ffi or the related patterns (like
_outlive), so please carefully review those bits in the PR.Thanks!
Matt