Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick new options methods from ngaut's fork #72

Merged
merged 17 commits into from Oct 26, 2016
Merged

Cherry pick new options methods from ngaut's fork #72

merged 17 commits into from Oct 26, 2016

Conversation

kaedroho
Copy link
Contributor

@kaedroho kaedroho commented Oct 26, 2016

Part of #69

This pull request ports the following changes from @ngaut's fork:

The following changes will be dealt with separately

Add set_iterator_upper_bound to ReadOptions https://github.com/ngaut/rust-rocksdb/pull/31

This changes the ownership of ReadOptions which we would like to avoid if possible

Add set_compaction_filter option https://github.com/ngaut/rust-rocksdb/pull/43

This change is big and porting it would be difficult as it's based on lots of refactoring

@kaedroho
Copy link
Contributor Author

Just added docstrings for most of the methods (including existing ones). These were copied from the RocksDB code itself (https://github.com/facebook/rocksdb/blob/869ae5d7868d7d48dd55b7be02a23581101ed69a/include/rocksdb/options.h).

They're quite inconsistent and have no examples, but it's much better than before!

@spacejam
Copy link
Member

Looks great! Thanks for this! I'll remove the 1.2 failing test now, since that's pretty ancient by rust standards now.

@spacejam spacejam merged commit c148def into rust-rocksdb:master Oct 26, 2016
@kaedroho kaedroho deleted the new-options-methods branch October 26, 2016 16:33
@kaedroho
Copy link
Contributor Author

Thanks for the quick review!

BusyJay pushed a commit to BusyJay/rust-rocksdb that referenced this pull request Jan 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants