compaction filter: allow to pass in owned variable for Decision::Change variant #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanislav-tkach
approved these changes
Jan 12, 2023
aleksuss
approved these changes
Jan 12, 2023
BusyJay
pushed a commit
to BusyJay/rust-rocksdb
that referenced
this pull request
Feb 5, 2023
* support sharing statistics Signed-off-by: tabokie <xy.tao@outlook.com> * use reference Signed-off-by: tabokie <xy.tao@outlook.com> * rearrange a bit Signed-off-by: tabokie <xy.tao@outlook.com> * add a test Signed-off-by: tabokie <xy.tao@outlook.com> * fmt Signed-off-by: tabokie <xy.tao@outlook.com> Signed-off-by: tabokie <xy.tao@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, reference to static variable is expected in
Decision::Changevariant, making it impossible to update the value based on a runtime context (what that value was holding, for example). RocksDB supports value changing, and static bound seems to be too restrictive.