Implement len() and is_empty() methods on WriteBatch #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
BusyJay
pushed a commit
to BusyJay/rust-rocksdb
that referenced
this pull request
Jul 7, 2017
BusyJay
pushed a commit
to BusyJay/rust-rocksdb
that referenced
this pull request
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #69
These changes we're ported from https://github.com/ngaut/rust-rocksdb/pull/22.
The original implementation named the
len()methodcount(). I renamed it tolen()to be more conventional with Rust.count()in Rust usually means that you have to actually "count" something that you do not know the length of, such as an iterator.len()in Rust usually means that you already know the length and can return it quickly. Looking at the RocksDB source code,countis just a value stored in memory so I think it makes sense for it to be namedlen()in the Rust API.