-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide git tags for binary crate releases #81
Comments
Thank you for packaging Could you point me to some documentation on how tags are used in packaging? I'd like to understand the use case better so that I don't break anything accidentally. Also, I understand the dependency versions are not tracked? So if I ship some important fix in a library crate, I should also cut a new release of the binary crates so that it gets into distros - is that correct? |
Also, would keeping the current tagging scheme for |
You're welcome! I'm very happy to see stuff like
https://github.com/void-linux/void-packages/pull/40265/files#diff-ca87b626d0d2e8ee6ae7022cff8cbbd40f794434d990f306ceab1ae3f1812f3fR11 would be an example here, https://github.com/void-linux/void-packages/blob/master/srcpkgs/sequoia-sq/template#L15 another one. It's not complicated, we basically just pull in the archive and put in the version number in the right place.
That would be the case either way, as for binary crates there's usually a Cargo.lock present. Until the Cargo.lock file is updated, rebuilding the application doesn't pull in newer library versions, so a new version with an updated Cargo.lock would then get picked up by distros.
Doesn't matter much, either way works for me. |
Alright, I'll use I've just published a new release of
I'd be very happy to see that happen! Please let me know if you need any changes in the tools to make that happen. Are you looking to use Come chat with us on Zulip if you want to discuss this further! |
|
I don't think we'll need any changes for that, no. In fact, most of the work there is already done: void-linux/void-packages#40272. The changes are in good shape, and so far the feedback has been positive, so I'm fairly hopeful that this will be merged soon, meaning we'll any newly built packages from then on will include the dependency tables :)
The
I'm mostly on matrix, never really got warm with zulip, so I'm unlikely to come around to just hang out, but I'll keep it in mind for when I have concrete questions that don't really fit into issues/PRs. Thanks! |
I see the PR for building Rust packages in Void Linux has been merged. I'm curious, when will it actually reach users? Like, is it going to apply to the next stable release, or is reaching users already through a rolling release? And are only newly built packages getting metadata embedded into them, or will there be a rebuild? |
It has already started reaching users, through a rolling release. For now, it only affects newly built packages, but I think we'll do a rebuild at some point, for the packages that don't get updated that often. I just checked: |
Do let me know if you run a rebuild - that'd be quite a milestone, and I'd be happy to announce it more widely! |
One small sidenote: Even with a rebuild, this only catches close to 90% of our rust packages. Places where cargo is not used by setting the build_style to cargo, but invoked in a Makefile or a meson build or something like that (which includes for example a few Gnome apps, but also our rust and cargo packages), those binaries don't contain the embedded metadata yet. Either way, when a rebuild happens, I'll be sure to let you know! |
I'm packaging
cargo-auditable
andrust-audit-info
for Void Linux, and for that it'd be very helpful to have git tags available for at least the binary crates. As far as I can tell, the tags already present are forcargo-auditable
itself, so this is mostly about providing tags forrust-audit-info
as well. An approach that works well for multiple projects with distinct versioning is using some tag prefix containing the crate name, like this for example: https://gitlab.com/openpgp-card/openpgp-card/-/issues/32#note_958397205The text was updated successfully, but these errors were encountered: