Use atomic counters #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The massive test fails on travic-ci in debug mode because the |
| @@ -221,7 +224,7 @@ mod test { | |||
| } | |||
| }); | |||
| } | |||
| sleep_ms(1000); | |||
| sleep_ms(1024); | |||
There was a problem hiding this comment.
I had it down to 10ms, but it was broken on some machines. then I choos a geeky number.
|
Looks great! Can you rebase and squash? |
| @@ -54,7 +55,8 @@ impl<'a> Sentinel<'a> { | |||
| impl<'a> Drop for Sentinel<'a> { | |||
| fn drop(&mut self) { | |||
| if self.active { | |||
| *self.thread_counter.write().unwrap() -= 1; | |||
| // TODO check return value and loop | |||
| (*self.thread_counter).fetch_sub(1, Ordering::SeqCst); | |||
- choose geeky numbers for tests - Add a new Test for massive task creation - Add new test for shrinking the pool - Let the test wait with a barrier not with a machine dependant sleep.
|
Rebased into one commit. Thank you for the review. |
| pub fn set_threads(&mut self, threads: usize) { | ||
| assert!(threads >= 1); | ||
| let current_max = self.max_count.lock().unwrap().clone(); | ||
| *self.max_count.lock().unwrap() = threads; | ||
| let current_max = (*self.max_count).swap(threads, Ordering::Release); |
|
Thanks for your contribution! 🎉 |
|
Version 1.0.2 has been released which includes these changes. |
|
Thank you, was a pleasure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried making the pool faster on NUMA systems but the effect is very minor, because the channel uses a Mutex.
However, since I already did the work, I would like to share it.
Should I rebase the history into one commit?