Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable #[deprecated] doc, requires rust 1.9 #38

Merged
merged 4 commits into from
Aug 20, 2016

Conversation

dns2utf8
Copy link
Member

@dns2utf8 dns2utf8 commented May 26, 2016

Rust 1.9 is stable now

@frewsxcv
Copy link
Collaborator

Minimum version in the .travis.yml file needs to be bumped.

@dns2utf8
Copy link
Member Author

Ah, you are right. Missed that.

Would you like to release a new version or should we wait until rust 1.9 is deployed more wideley?

@frewsxcv
Copy link
Collaborator

Would you like to release a new version or should we wait until rust 1.9 is deployed more wideley?

I might wait a week or two to merge this PR. I'll add a reminder for myself.

@dns2utf8
Copy link
Member Author

Thank you.

I seem to have borken the build by removing this line from the before_script:

pip install 'travis-cargo<0.2' --user && export PATH=$HOME/.local/bin:$PATH

Did it install cargo for the 1.4 build?

@frewsxcv
Copy link
Collaborator

travis-cargo is used to automatically generate documentation and deploy it to GitHub pages so I dont think we want to get rid of it.

https://github.com/huonw/travis-cargo

@dns2utf8
Copy link
Member Author

Yes this would be a very inconvenient change.

Also I enabled the cargo cache with this PR.

Would you like to issue a hint in the README or the CHANGELOG for the new minimal version of the compiler?

@frewsxcv
Copy link
Collaborator

Would you like to issue a hint in the README or the CHANGELOG for the new minimal version of the compiler?

Yep sounds good.

@dns2utf8 dns2utf8 changed the title Deprecation doc Deprecation doc, requires rust 1.9 May 26, 2016
@dns2utf8 dns2utf8 changed the title Deprecation doc, requires rust 1.9 Enable #[deprecated] doc, requires rust 1.9 May 26, 2016
@dns2utf8
Copy link
Member Author

dns2utf8 commented May 26, 2016

Done.

I am currently thinking about the release. I see two views:

  • rust 1.4 users: they see a breaking change, so the version should go to 2.0
  • rust stable users: they see some new docs and a compiler hint, so the version should go to 1.3.1

Currently there seem to be only two distros providing a package for rust:

  • Arch currently 1.8, will be updated very soon so not a problem
  • Debian currently 1.8 in testing, 1.9 should land in unstable soon

I have to rethink what way I would favor. A min-version flag in cargo would solve this problem.

@kamalmarhubi
Copy link

Possibly relevant: there's an RFC for Rust version support policy for rust-lang-nursery crates. The suggested policy is current + last two stable releases. Link: rust-lang/rfcs#1619

@frewsxcv
Copy link
Collaborator

frewsxcv commented Jun 8, 2016

Possibly relevant: there's an RFC for Rust version support policy for rust-lang-nursery crates. The suggested policy is current + last two stable releases. Link: rust-lang/rfcs#1619

Sounds good. I'm not in a rush to merge this. Just moved my alarm to August 19th (the day after Rust 1.11.0 is planned to be released).

@frewsxcv
Copy link
Collaborator

1.11.0 is out. This should be good to go now. @dns2utf8 can you rebase?

@dns2utf8
Copy link
Member Author

Thanks for the reminder 😄
Rebased and updated the CHANGES.md

@frewsxcv
Copy link
Collaborator

Thanks!

@frewsxcv frewsxcv merged commit 3191674 into rust-threadpool:master Aug 20, 2016
@dns2utf8 dns2utf8 deleted the patch-1 branch August 21, 2016 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants