-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable #[deprecated]
doc, requires rust 1.9
#38
Conversation
Minimum version in the |
Ah, you are right. Missed that. Would you like to release a new version or should we wait until rust 1.9 is deployed more wideley? |
I might wait a week or two to merge this PR. I'll add a reminder for myself. |
Thank you. I seem to have borken the build by removing this line from the before_script: pip install 'travis-cargo<0.2' --user && export PATH=$HOME/.local/bin:$PATH Did it install cargo for the 1.4 build? |
travis-cargo is used to automatically generate documentation and deploy it to GitHub pages so I dont think we want to get rid of it. |
Yes this would be a very inconvenient change. Also I enabled the cargo cache with this PR. Would you like to issue a hint in the README or the CHANGELOG for the new minimal version of the compiler? |
Yep sounds good. |
#[deprecated]
doc, requires rust 1.9
Done. I am currently thinking about the release. I see two views:
Currently there seem to be only two distros providing a package for rust:
I have to rethink what way I would favor. A min-version flag in cargo would solve this problem. |
Possibly relevant: there's an RFC for Rust version support policy for rust-lang-nursery crates. The suggested policy is current + last two stable releases. Link: rust-lang/rfcs#1619 |
Sounds good. I'm not in a rush to merge this. Just moved my alarm to August 19th (the day after Rust 1.11.0 is planned to be released). |
1.11.0 is out. This should be good to go now. @dns2utf8 can you rebase? |
Thanks for the reminder 😄 |
Thanks! |
Rust 1.9 is stable now