Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Docs and raise minimal rustc version to 1.13.0 #99

Merged
merged 6 commits into from
Mar 2, 2019
Merged

Improved Docs and raise minimal rustc version to 1.13.0 #99

merged 6 commits into from
Mar 2, 2019

Conversation

dns2utf8
Copy link
Member

Hi All

I added some documentation:

  • Explicit magic constant
  • Remove the last warning while running the tests
  • Document the development with rustup

Best,
Stefan

@dns2utf8
Copy link
Member Author

dns2utf8 commented Feb 27, 2019 •
edited
Loading

So it turns out that libc > 0.2.40 require rust 1.13.0 or later.
@frewsxcv Should we up our requirements too?

@dns2utf8 dns2utf8 changed the title Improoved Docs Improved Docs Feb 27, 2019
@dns2utf8 dns2utf8 mentioned this pull request Feb 27, 2019
Closed
@frewsxcv
Copy link
Collaborator

frewsxcv commented Mar 2, 2019

Yeah, I think it's fine to bump to 1.13.0

@frewsxcv
Copy link
Collaborator

frewsxcv commented Mar 2, 2019

Also FYI, I just gave you 'owner' privileges for this GH Org

@dns2utf8
Copy link
Member Author

dns2utf8 commented Mar 2, 2019

Perfect.
Thank you for the access :)

bors r+

bors bot added a commit that referenced this pull request Mar 2, 2019
@bors @dns2utf8
Merge #99
07d1a5b 
99: Improved Docs r=dns2utf8 a=dns2utf8

Hi All

I added some documentation:
* Explicit magic constant
* Remove the last warning while running the tests
* Document the development with rustup

Best,
Stefan

Co-authored-by: Stefan Schindler <stefan@estada.ch>
@dns2utf8 dns2utf8 changed the title Improved Docs Improved Docs and raise minimal rustc version to 1.13.0 Mar 2, 2019
@bors
Copy link
Contributor

bors bot commented Mar 2, 2019

Build succeeded

@bors bors bot merged commit 8d81e18 into rust-threadpool:master Mar 2, 2019
@dns2utf8 dns2utf8 deleted the docs branch March 3, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frewsxcv frewsxcv frewsxcv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dns2utf8 @frewsxcv