Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deny warnings page is out of date #89

Closed
mvertescher opened this issue Nov 12, 2019 · 1 comment · Fixed by #213
Closed

Deny warnings page is out of date #89

mvertescher opened this issue Nov 12, 2019 · 1 comment · Fixed by #213
Labels
A-anti_pattern Area: Content about Anti-Patterns C-outdated Category: Content that is outdated and needs a rework
Projects

Comments

@mvertescher
Copy link

The deny warnings page is a little out of date and should be updated to remove warnings that are no longer relevant.

@simonsan simonsan added the C-outdated Category: Content that is outdated and needs a rework label Dec 31, 2020
@simonsan simonsan added this to To do in Content Jan 2, 2021
@simonsan
Copy link
Collaborator

simonsan commented Jan 2, 2021

I wonder if it might be a better approach instead of listing single warnings that could be safe to deny (which will probably change more often in the future as well), to point to rustc -W help and let people pick the warnings they want to deny from that list by themselves. With the mindset: "If you want to deny single warnings please be responsible and pick yourself. We give you a recommendation which allowed lint checks might make sense to deny as well.

Also we could name lint groups provided by rustc rather than single lints.

Thoughts?

@simonsan simonsan added the A-anti_pattern Area: Content about Anti-Patterns label Jan 21, 2021
@simonsan simonsan moved this from To do to ToDo-Anti-Patterns in Content Jan 21, 2021
Content automation moved this from ToDo-Anti-Patterns to Done Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-anti_pattern Area: Content about Anti-Patterns C-outdated Category: Content that is outdated and needs a rework
Projects
Development

Successfully merging a pull request may close this issue.

2 participants