Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for rustbook build via mirror #13

Merged
merged 4 commits into from Aug 9, 2015
Merged

Add instructions for rustbook build via mirror #13

merged 4 commits into from Aug 9, 2015

Conversation

jameslzhu
Copy link
Contributor

Replaces old instructions of compiling rustc from scratch.

Instead of compiling rustc, I've found a mirror of the rustbook code.

Both rustbook and the book compile without problems on my Linux box:
Arch Linux x86_64 (kernel 4.1.3-1-ARCH)
rustc 1.3.0-nightly (4dfe7a16c 2015-07-30)
cargo 0.4.0-nightly (e0a82d6 2015-07-29) (built 2015-07-30)

I'm fairly certain most people will want to avoid bootstrapping the entire rustc compiler if the mirror works just as well.

@Gankra
Copy link
Collaborator

Gankra commented Aug 3, 2015

I gave these instruction specifically because it didn't work on my mac.

Have you built rustc on your machine before?

@jameslzhu
Copy link
Contributor Author

Would it be better if I added both sets of instructions to the readme then?

@Gankra
Copy link
Collaborator

Gankra commented Aug 3, 2015

I'll try to use steve's fork again first...

@Gankra
Copy link
Collaborator

Gankra commented Aug 3, 2015

Yeah I just get

rustbook::./target/release/rustbook
dyld: Library not loaded: x86_64-apple-darwin/stage2/lib/rustlib/x86_64-apple-darwin/lib/librustdoc-74fa456f.dylib
  Referenced from: /Users/ABeingessner/dev/rustbook/./target/release/rustbook
  Reason: image not found
Trace/BPT trap: 5

As usual. Maybe it's because I do build the compiler or maybe it's because I use multirust. shrug

@jameslzhu
Copy link
Contributor Author

I'm running multirust as well (multirust 0.0.6 (6b18101d0 2015-04-30 14:40:11 -0700), so I don't think that's the issue.
For now, I'll add your instructions in as a fallback in case people encounter your error.
Sound good?

@Gankra
Copy link
Collaborator

Gankra commented Aug 3, 2015

👍

@Gankra
Copy link
Collaborator

Gankra commented Aug 3, 2015

I have a sneaking suspicion it's because you and @steveklabnik use Linux -- but also dynamic linking is just dumb and butts.

@jameslzhu
Copy link
Contributor Author

Ready to go.

Also, yes, dynamic linking has bitten me way too many times.

@Gankra
Copy link
Collaborator

Gankra commented Aug 3, 2015

Can you add rustbook specifically to the end of the path? I reckon that's a bit easier to copy-paste as appropriate (and means they don't have to think about it).

@Gankra
Copy link
Collaborator

Gankra commented Aug 9, 2015

Whoops, didn't notice you did the fix I requested (github doesn't notify about pushes).

Thanks a bunch!

Gankra added a commit that referenced this pull request Aug 9, 2015
Add instructions for rustbook build via mirror
@Gankra Gankra merged commit 50c9cff into rust-unofficial:master Aug 9, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants