Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add KVM_TRANSLATE and translate_gva #191

Merged
merged 1 commit into from Jan 24, 2022

Conversation

retrage
Copy link
Contributor

@retrage retrage commented Jan 22, 2022

This PR adds support for KVM_TRANSLATE and function translate_gva,
translates guest virtual address to the physical address by calling
ioctl as described in [1].

This feature is needed to implement GDB support for Cloud Hypervisor[2].

[1] https://www.kernel.org/doc/Documentation/virtual/kvm/api.txt
[2] cloud-hypervisor/cloud-hypervisor#3575

acatangiu
acatangiu previously approved these changes Jan 24, 2022
Copy link
Collaborator

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes look good, just a couple of nice-to-have nits.

src/ioctls/vcpu.rs Outdated Show resolved Hide resolved
src/ioctls/vcpu.rs Outdated Show resolved Hide resolved
@acatangiu
Copy link
Collaborator

acatangiu commented Jan 24, 2022

You need to sign add a signed-off-by line to the last commit, you can do that by simply calling git commit -s --amend.

But since you need to push -f anyway, I suggest you also squash the two commits in a single one.

This commit adds support for KVM_TRANSLATE and function translate_gva,
translates guest virtual address to the physical address by calling
ioctl as described in [1].

[1] https://www.kernel.org/doc/Documentation/virtual/kvm/api.txt

Signed-off-by: Akira Moroo <retrage01@gmail.com>
Co-authored-by: Adrian Catangiu <adrian@parity.io>
@retrage
Copy link
Contributor Author

retrage commented Jan 24, 2022

Thank for the suggestion, I pushed 536a35f.

@lauralt lauralt merged commit 97ff779 into rust-vmm:main Jan 24, 2022
@rbradford
Copy link
Contributor

Thanks all for helping @retrage!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants