Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libc update #71

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Libc update #71

merged 2 commits into from
Mar 18, 2024

Conversation

boustrophedon
Copy link
Contributor

Summary of the PR

Updates libc and resolves #60.

There is no new or changed public functionality so I didn't update the changelog.

Requirements

Before submitting your PR, please make sure you addressed the following
requirements:

  • All commits in this PR have Signed-Off-By trailers (with
    git commit -s), and the commit message has max 60 characters for the
    summary and max 75 characters for each description line.
  • All added/changed functionality has a corresponding unit/integration
    test.
  • All added/changed public-facing functionality has entries in the "Upcoming
    Release" section of CHANGELOG.md (if no such section exists, please create one).
  • Any newly added unsafe code is properly documented.

Signed-off-by: Harry Stern <harry@harrystern.net>
@boustrophedon
Copy link
Contributor Author

Whoops, minor fixup.

@boustrophedon
Copy link
Contributor Author

\"\ cargo\ build\ --release\ --features=json
    Updating crates.io index
 Downloading crates ...
warning: spurious network error (2 tries remaining): failed to get successful HTTP response from `https://crates.io/api/v1/crates/proc-macro2/1.0.78/download`, got 503

Looks like crates.io had a blip and I'm not sure how to retry the build

Use libc constants now that rust-lang/libc/pull/3343 is merged and
released.

SECCOMP_RET_MASK does not exist anymore and appears to have not existed
for a while. SECCOMP_RET_DATA is exactly the same mask value, and the
usage here is in line with the man page.

Completes rust-vmm#60

Signed-off-by: Harry Stern <harry@harrystern.net>
@boustrophedon
Copy link
Contributor Author

I moved the imports to the file they're actually used in mostly so that I could retry the build and it's passing now. I can move them back if anyone thinks they're better off in the bpf.rs file.

Copy link
Collaborator

@alindima alindima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@alindima alindima merged commit b6907ec into rust-vmm:main Mar 18, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use libc's seccomp-related constants
3 participants