Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vsock: cargo-audit reports that yaml-rust is unmaintained #639

Open
stefano-garzarella opened this issue Mar 26, 2024 · 3 comments
Open

vsock: cargo-audit reports that yaml-rust is unmaintained #639

stefano-garzarella opened this issue Mar 26, 2024 · 3 comments

Comments

@stefano-garzarella
Copy link
Member

In vhost-device-vsock we use the config crate which now has a dependency that is unmaintained as cargo audit is reporting.

I reported to them here: mehcode/config-rs#553

For now we don't have a new version available, so we can wait a bit or find an alternative.
@epilys
Copy link
Member

epilys commented Mar 26, 2024

An alternative would be to switch to toml, WDYT?

@stefano-garzarella
Copy link
Member Author

An alternative would be to switch to toml, WDYT?

yeah, I think we can wait a bit to understand their plan, if they will not fix it, we can switch to toml.
Not great as a change, but we are not stable at all, so it could be okay to change our config format.

@stefano-garzarella stefano-garzarella mentioned this issue Mar 27, 2024
Open
4 tasks
@stefano-garzarella
Copy link
Member Author

They just switched to yaml-rust2 which seems maintained, so we just need to wait for a new config release. I asked about that.

stefano-garzarella added a commit to stefano-garzarella/vhost-device that referenced this issue Mar 29, 2024
@stefano-garzarella
Use a patched version for the config dependency
8387d1a 
In vhost-device-vsock we use the `config` crate which now has the `yaml-rust`
dependency that is unmaintained as cargo audit is reporting.
See rust-vmm#639

They merged the fix, but for now they don't do a release because they don't
have a maintainer. To get the CI green, let's do this workaround, but before
the next release we have to find a solution.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
@stefano-garzarella stefano-garzarella mentioned this issue Mar 29, 2024
Merged
vireshk pushed a commit that referenced this issue Apr 2, 2024
@stefano-garzarella @vireshk
Use a patched version for the config dependency
629c731 
In vhost-device-vsock we use the `config` crate which now has the `yaml-rust`
dependency that is unmaintained as cargo audit is reporting.
See #639

They merged the fix, but for now they don't do a release because they don't
have a maintainer. To get the CI green, let's do this workaround, but before
the next release we have to find a solution.

Signed-off-by: Stefano Garzarella <sgarzare@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stefano-garzarella @epilys