-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yet another interrupt traits pull request #23
Open
bonzini
wants to merge
1
commit into
rust-vmm:main
Choose a base branch
from
bonzini:irq_v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwmw2
reviewed
Mar 5, 2020
dwmw2
reviewed
Mar 5, 2020
7298cf0
to
242fb52
Compare
@jiangliu Seeing your SOB on this one, I assume you're ok with that implementation? |
No, SoB only tracks the provenance of the code. |
Anybody willing to review this or even try to integrate it in c-h? @sboeuf? :) |
Any news? |
I got pulled into migration stuff for CH, I don't have the bandwidth for now. |
Well, even a review can help... |
Introduce traits InterruptManager and Interrupt to manage interrupt sources for virtual devices. Signed-off-by: Liu Jiang <gerry@linux.alibaba.com> Signed-off-by: Bin Zha <zhabin@linux.alibaba.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
This was referenced Jun 8, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce traits InterruptManager and Interrupt to manage interrupt sources for virtual devices, as well as a Vec wrapper that includes convenience
enable
anddisable
methods.See also discussion in #21