Relax assertions for zero-length accesses (for v0.1.2) #107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #106
Relax the assertions from
write_to
andread_from
to allow equality betweenoffset
andcount
, which no longer leads to panics when zero-length accesses happen. This is preferred versus adding an explicit check forcount
orlen == 0
somewhere, because we don't end up with an additional branch on the regular path. Also tweaked thetry_access
logic a bit, to returnOk(0)
whentotal == 0
but we found a valid region associated with the current address (which indicates a zero-length access).