virtio core support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonzini
reviewed
May 15, 2019
bonzini
requested changes
May 16, 2019
sameo
force-pushed
the
topic/virtio-core
branch
3 times, most recently
from
8f1b5c1
to
40913d1
Compare
petreeftime
reviewed
May 20, 2019
sameo
force-pushed
the
topic/virtio-core
branch
3 times, most recently
from
34b7af2
to
ffc60dc
Compare
andreeaflorescu
previously approved these changes
May 27, 2019
bonzini
previously approved these changes
May 28, 2019
|
Since I don't have write access, my approval doesn't count for merging. |
|
@bonzini added you as collaborator. |
aghecenco
reviewed
May 28, 2019
added 5 commits
May 29, 2019 11:13
This is based on Firecracker v0.16 and ported to the rust-vmm memory model. It implements the virtio virtqueue specification for virtio devices. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
In order to simplify the iter and add_used methods. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
This is based on crosvm 107edb3e, with removal for all PCI specific bits and the GuestMemory generics dependency addition. As it depends on the EventFd API, this introduces a vmm-sys-util dependency. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Add the Apache-2.0 and BSD-3-Clause licenses for this crate, and dual license Apache-2.0 OR/AND BSD-3-Clause. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Provide a crate description, a brief API documentation and some testing instructions. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
|
@aghecenco I addressed most of your comments, PTAL. |
added 4 commits
May 29, 2019 11:22
And update the corresponding README sections. Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
See https://buildkite.com/docs/pipelines/defining-steps Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
The linker can't find the floating point builtins. Added target-feature=+crt-static and link-arg=-lgcc as a temporary workaround. This seems to be the accepted fix in the Rust community: rust-lang/compiler-builtins#201 Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
aghecenco
approved these changes
May 29, 2019
|
Summary of issues to create after this is merged:
|
bonzini
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings the initial support for virtio devices:
Devicetrait based on crosvm 107edb3e