ndk-build: Add ndk_gdb() function to acquire ndk-gdb script path with the correct per-platform extension
#330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See also #258, nobody tested it but I don't remember what was wrong with it. |
|
This PR has been tested and is in active use at least. |
38 tasks
Jasper-Bekkers
force-pushed
the
incorrect-paths
branch
from
f835d85
to
16b423d
Compare
|
Rebased :-) |
|
Thanks, but I think this may conflict with #331 which I was looking at getting in first 😬 |
|
No worries, I can rebase again after. |
MarijnS95
changed the title
ndk_gdb() function to acquire ndk-gdb script path with the correct per-platform extension
MarijnS95
force-pushed
the
incorrect-paths
branch
from
4e6ab0b
to
8049b3a
Compare
MarijnS95
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path to the gdb script wasn't generated properly (was missing the
.cmdextension) and thedetect_abiwas similarly broken on windows.