Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ndk-build: Add ndk_gdb() function to acquire ndk-gdb script path with the correct per-platform extension #330

Merged
merged 4 commits into from
Sep 8, 2022

Conversation

Jasper-Bekkers
Copy link
Contributor

The path to the gdb script wasn't generated properly (was missing the .cmd extension) and the detect_abi was similarly broken on windows.

@MarijnS95
Copy link
Member

See also #258, nobody tested it but I don't remember what was wrong with it.

@Jasper-Bekkers
Copy link
Contributor Author

This PR has been tested and is in active use at least.

@Jasper-Bekkers
Copy link
Contributor Author

Rebased :-)

@MarijnS95
Copy link
Member

Thanks, but I think this may conflict with #331 which I was looking at getting in first 😬

@Jasper-Bekkers
Copy link
Contributor Author

No worries, I can rebase again after.

@MarijnS95 MarijnS95 changed the title Fix some incorrect paths ndk-build: Add ndk_gdb() function to acquire ndk-gdb script path with the correct per-platform extension Sep 8, 2022
@MarijnS95 MarijnS95 merged commit 78c80c1 into rust-mobile:master Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants