Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate all (recursively) added runtime libraries #333

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Deduplicate all (recursively) added runtime libraries #333

merged 4 commits into from
Sep 5, 2022

Conversation

Jasper-Bekkers
Copy link
Contributor

@Jasper-Bekkers Jasper-Bekkers commented Aug 30, 2022 •
edited

Builds on #246 but cleans it up a bit.

We started to run into this since the Vulkan-SDK started building with libc++_shared.so in KhronosGroup/Vulkan-ValidationLayers@a64eec0

@Jasper-Bekkers Jasper-Bekkers mentioned this pull request Aug 30, 2022
Open
38 tasks
MarijnS95
MarijnS95 reviewed Aug 30, 2022
View reviewed changes
Copy link
Member

@MarijnS95 MarijnS95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This almost implements #246 in the way suggested, just one comment/request.

ndk-build/src/apk.rs Outdated Show resolved Hide resolved
@MarijnS95 MarijnS95 changed the title Dedup recursively found libraries. Deduplicate all (recursively) added runtime libraries Sep 5, 2022
@MarijnS95 MarijnS95 merged commit b844601 into rust-mobile:master Sep 5, 2022
@MarijnS95 MarijnS95 mentioned this pull request Dec 22, 2022
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarijnS95 MarijnS95 MarijnS95 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Jasper-Bekkers @MarijnS95