Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate runtime library deduplication #12

Open
2 tasks
MarijnS95 opened this issue Sep 5, 2022 · 0 comments
Open
2 tasks

Consolidate runtime library deduplication #12

MarijnS95 opened this issue Sep 5, 2022 · 0 comments

Comments

@MarijnS95
Copy link
Member

We merged a first stab at deduplicating runtime libraries in rust-mobile/ndk#333, to prevent cargo-apk from complaining that an identically-named library (or file in general) has been added twice (when two or more recursively added libraries depend on the same thing).

There may however be a few things to improve:

  • Don't (recursively) search for libraries when they've already been found and are pending inclusion;
  • When the source path (and checksum) for a duplicate library differs (i.e. something found in the search path versus an identically named file specified in runtime_libs), warn the user as this might not be intended.
@dvc94ch dvc94ch transferred this issue from rust-mobile/ndk Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant