ndk-build: Consider ANDROID_SDK_ROOT as deprecated instead of ANDROID_HOME #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
ndk-build-swap-sdk-env-vars
branch
from
85a8794
to
229c929
Compare
MarijnS95
force-pushed
the
ndk-build-swap-sdk-env-vars
branch
4 times, most recently
from
f9dc492
to
ca7f9a2
Compare
|
Thank you for fixing it 👍🙏 |
msiglreith
approved these changes
Sep 12, 2022
…_HOME According to the [official documentation] `ndk-build` is considering the wrong variable as deprecated. The wrong message was introduced in [#39] which bizarrely failed to quote any reference matterial on the matter, making it impossible to understand whether this has always been the case or recently switched in precedence. [official documentation]: https://developer.android.com/studio/command-line/variables [#39]: #39
MarijnS95
force-pushed
the
ndk-build-swap-sdk-env-vars
branch
from
ca7f9a2
to
fa88fd4
Compare
MarijnS95
pushed a commit
to rust-mobile/cargo-apk
that referenced
this pull request
Nov 30, 2023
…ot found (#35) Per rust-mobile/ndk#346 `ANDROID_HOME` is the recommended environment variable over `ANDROID_SDK_ROOT`, but the error message when no SDK is found at all was still pointing to `ANDROID_SDK_ROOT`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #327, CC @Hoodad
According to the official documentation
ndk-buildis considering the wrong variable as deprecated. The wrong message was introduced in #39 which bizarrely failed to quote any reference matterial on the matter, making it impossible to understand whether this has always been the case or recently switched in precedence.