Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to choice between EGL and GLX on linux, without changing the opengl version. #1140

Closed
goddessfreya opened this issue Apr 8, 2019 · 6 comments
Assignees

Comments

@goddessfreya
Copy link
Contributor

No description provided.

@sumit0190
Copy link
Contributor

@zegentzy Are you working on this already? I started using this in a project a couple of days ago and I thought "this'd be a nice-to-have" and started hacking on it, but only later realized that this was made into an issue already.

@goddessfreya
Copy link
Contributor Author

goddessfreya commented Jun 22, 2019

If you already have it done against master, I'd be happy to merge it in for v0.22.

I'm only working on having this ready for v0.23, via the upcoming plat_attrs in ContextBuilder.

@sumit0190
Copy link
Contributor

Oh I'd have to clean it up by loads: what I have right now is a terrible hack I put in just to test my logic with both EGL and GLX.
I see that PlatformAttributes isn't in yet; maybe we should take this up AFTER you push your changes in?

@goddessfreya
Copy link
Contributor Author

Well yeah, cause like I said, I only intend to have it in for v0.23. If you want it in v0.22, you can backport the neccecary changes and put up a PR.

@sumit0190
Copy link
Contributor

Sure thing, I'll wait; until then I'll look at other issues I can contribute to. Thanks!

@goddessfreya
Copy link
Contributor Author

Implemented in v0.24. See #1271. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants