Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer core::ffi::c_void type over libc::c_void #3

Closed
Lokathor opened this issue Jul 26, 2019 · 1 comment · Fixed by #51
Closed

Prefer core::ffi::c_void type over libc::c_void #3

Lokathor opened this issue Jul 26, 2019 · 1 comment · Fixed by #51

Comments

@Lokathor
Copy link
Contributor

All c_void are in some sense similar since you can always just cast between them, however, since core offers a c_void type we should at least use that common point of communication as much as possible.

@Osspial
Copy link
Contributor

Osspial commented Aug 5, 2019

I'm not opposed to doing this, but it's worth noting that we'll still have to pull in libc to maintain no_std compatibility on Linux, since X11 uses a c_ulong to represent the window handle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants