Add GTK handles #105
Add GTK handles #105
Conversation
src/unix.rs
Outdated
| #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash)] | ||
| pub struct Gtk4DisplayHandle { | ||
| /// A pointer to a `GtkApplication`. | ||
| pub display: *mut c_void, |
There was a problem hiding this comment.
Both GTK3 and GTK4 can be used without a GtkApplication. I guess NULL could be used in that case? What would the GtkApplication be needed for?
There was a problem hiding this comment.
In any case, shouldn't this actually be a GdkDisplay?
There was a problem hiding this comment.
Yeah, GdkDisplay is probably the closest thing to a "display handle" in GTK. It has subclasses like which in turn holds things like wl_display.
Normally the display is just global state you can get with gdk_display_get_default(). I don't know if GTK can ever work with a display that isn't the "default".
There was a problem hiding this comment.
Since GdkDisplay is at the level below GTK, I wanted to avoid exposing it. I can add it anyways, if you want.
Both GTK3 and GTK4 can be used without a GtkApplication. I guess NULL could be used in that case? What would the GtkApplication be needed for?
Yes, it can be null without any issues. GtkApplication can be used to tinker with the menu bar, which may actually be important in many cases.
There was a problem hiding this comment.
That sounds somewhat reasonable, though I think we're using RawDisplayHandle wrongly for this, then? Like, ideally we should have Raw{Application, Display, Window, Surface, ...}Handle?
Anyhow, at the very least the variable should be renamed from display to application.
There was a problem hiding this comment.
If the window is associated with an application, you can get it with gtk_window_get_application(). So it seems redundant, and possibly better to just leave the display handle empty like WebDisplayHandle.
There was a problem hiding this comment.
I still think that we should have a pointer to it, if for no other reason than to elide a call to gtk_window_get_application().
notgull
force-pushed
the
gtk
branch
2 times, most recently
from
6f5d0f4
to
02bbb91
Compare
|
If this takes a "A pointer to a |
|
The more that I think about this, the more I think that we should discuss first how higher-level toolkits like GTK and Qt should integrate into this crate. I'll close this for now. |
This PR adds handles representing display and window handles for GTK 3 and 4.