Skip to content

Commit

Permalink
On macOS, fix key_up being ignored without IME
Browse files Browse the repository at this point in the history
Fixes: d15feb5 (On macOS, fix empty marked text)
  • Loading branch information
kchibisov committed May 6, 2023
1 parent b455f88 commit 870e6d1
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Expand Up @@ -8,6 +8,8 @@ And please only add new entries to the top of this list, right below the `# Unre

# Unreleased

- On macOS, fix `key_up` beind ignored when `Ime` is disabled.

# 0.28.4

- On macOS, fix empty marked text blocking regular input.
Expand Down
2 changes: 1 addition & 1 deletion src/platform_impl/macos/view.rs
Expand Up @@ -549,7 +549,7 @@ declare_class!(
self.update_potentially_stale_modifiers(event);

// We want to send keyboard input when we are currently in the ground state.
if self.state.ime_state == ImeState::Ground {
if matches!(self.state.ime_state, ImeState::Ground | ImeState::Disabled) {
#[allow(deprecated)]
self.queue_event(WindowEvent::KeyboardInput {
device_id: DEVICE_ID,
Expand Down

0 comments on commit 870e6d1

Please sign in to comment.