Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move hidpi_factor to MonitorId #315

Closed
jwilm opened this issue Oct 9, 2017 · 4 comments · Fixed by #548
Closed

Move hidpi_factor to MonitorId #315

jwilm opened this issue Oct 9, 2017 · 4 comments · Fixed by #548
Labels
C - waiting on author Waiting for a response or another PR D - average Likely as difficult as most tasks here P - normal Great to have S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
HiDPI Support

Comments

@jwilm
Copy link
Contributor

jwilm commented Oct 9, 2017

This would allow the device-pixel-ratio to be determined before creating a window. Alacritty's use case for this is showing a correctly dimensioned window at startup without having a flash of the incorrectly sized window. This is because terminal size is usually dictacted by lines/columns requested, and that requires the scale factor to compute.
@tomaka tomaka added S - api Design and usability S - enhancement Wouldn't this be the coolest? labels Oct 9, 2017
@elinorbgr elinorbgr mentioned this issue Oct 9, 2017
Closed
@kryptan
Copy link
Contributor

kryptan commented Oct 9, 2017

Do you want to remove hidpi_factor from Window? I think it should be in both Window and MonitorId. You could have Window which is scaled by OS and thus has different hidpi_factor than the monitor it is located at.

@jwilm
Copy link
Contributor Author

jwilm commented Oct 9, 2017

@kryptan perhaps. We should probably figure that out in #105

@elinorbgr
Copy link
Contributor

Has #319 Solved this?

@jwilm
Copy link
Contributor Author

jwilm commented Oct 21, 2017

I guess that depends on the definition of solved. #319 just stubbed out methods on MonitorId rather than implement them.

@elinorbgr elinorbgr mentioned this issue Oct 25, 2017
Closed
@francesca64 francesca64 added D - easy Likely easier than most tasks here P - normal Great to have C - waiting on author Waiting for a response or another PR D - average Likely as difficult as most tasks here and removed D - easy Likely easier than most tasks here labels May 6, 2018
@francesca64 francesca64 added this to the HiDPI Support milestone May 8, 2018
@francesca64 francesca64 mentioned this issue Jun 3, 2018
Merged
tmfink pushed a commit to tmfink/winit that referenced this issue Jan 5, 2022
@pcwalton
Merge pull request rust-windowing#315 from pcwalton/metal-timing
a373a1f 
Reduce timing jitter in the Metal backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C - waiting on author Waiting for a response or another PR D - average Likely as difficult as most tasks here P - normal Great to have S - api Design and usability S - enhancement Wouldn't this be the coolest?
Milestone
HiDPI Support
Development

Successfully merging a pull request may close this issue.

DPI for everyone francesca64/winit
5 participants
@tomaka @francesca64 @elinorbgr @jwilm @kryptan