Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entries from PULL_REQUEST_TEMPLATE.md that are now covered by CI #2126

Merged
merged 1 commit into from Jan 5, 2022

Conversation

rukai
Copy link
Contributor

@rukai rukai commented Jan 3, 2022

  • Tested on all platforms changed
  • Compilation warnings were addressed
  • cargo fmt has been run on this branch
  • cargo doc builds successfully
  • Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

The more entries there are, the more likely people are to start just ignoring them all.
By removing the ones already covered by CI then the remaining entries are more likely to be followed.

Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, had this on the TODO-list as well, thanks!

@madsmtm madsmtm added the S - docs Awareness, docs, examples, etc. label Jan 3, 2022
@rukai rukai force-pushed the cleanup_pull_request_template branch from 714aef1 to 6a3d970 Compare January 4, 2022 01:47
@rukai
Copy link
Contributor Author

rukai commented Jan 4, 2022

I'm not sure why the builds arent running.
I tried force pushing to trigger it but that didnt work.
Maybe github has some kind of security feature blocking it since I touched .github/?

@rukai rukai force-pushed the cleanup_pull_request_template branch from 6a3d970 to d36c227 Compare January 4, 2022 01:51
@maroider
Copy link
Member

maroider commented Jan 4, 2022

I'm not sure why the builds arent running.

Our CI config makes GitHub confused. See #2130.

@maroider
Copy link
Member

maroider commented Jan 5, 2022

Since #2130 has been merged, CI ought to run once you force-push again. If that doesn't work, then you may need to rebase onto master.

@rukai rukai force-pushed the cleanup_pull_request_template branch from d36c227 to c5ca170 Compare January 5, 2022 15:02
@madsmtm
Copy link
Member

madsmtm commented Jan 5, 2022

Nice, thanks!

@madsmtm madsmtm merged commit 8af222c into rust-windowing:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S - docs Awareness, docs, examples, etc.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants