Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a transparent color for the transparent example #3048

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

stefnotch
Copy link

@stefnotch stefnotch commented Aug 25, 2023

  • Tested on all platforms changed
  • Created or updated an example program if it would help users understand this functionality

The transparency example used a solid fill color, which seems a tad odd. This fixes this by using a semi-transparent gray. However, we should wait for softbuffer to support transparency. rust-windowing/softbuffer#17
I only have a Windows machine, so I only managed to test the example on Windows.

The example can be tested with cargo run --example transparent

@stefnotch
Copy link
Author

I'd love some advice on how to fix the CI.

@madsmtm
Copy link
Member

madsmtm commented Aug 25, 2023

I'd love some advice on how to fix the CI.

Maybe just slap a #[allow(dead_code)] on fill_window?

@stefnotch stefnotch marked this pull request as draft August 26, 2023 20:42
@kchibisov
Copy link
Member

Allowing dead code sounds fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants