Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On wasm, provide intradoc-link for
spawn()
function inEventLoop
docs #3178On wasm, provide intradoc-link for
spawn()
function inEventLoop
docs #3178Changes from all commits
2b33b97
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not super happy with this, because it'll fail to link on
not(all(wasm_platform, target_feature = "exception-handling"))
(which is strange, because features must be additive and should not remove functionality).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
target_feature = "exception-handling"
isn't stable, which is probably why it didn't work for you.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daxpedda reading this again, I missed
target_
and assumed it was justfeature =
(from the[features]
list inCargo.toml
).I think the feature must have been _en_abled (running nightly rustdoc for
--cfg docsrs
=>doc_cfg
), as it's the only way to causenot(all(true, true)) = not(true) = false
and turn offfn run()
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is weird,
target_feature = "exception-handling"
should not automatically have been enabled by running nightly rustdoc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't want this PR to turn into a "let's fix all
winit
intradoc links", but a few more changes are still needed to make this consistent.No clue what the point is with manual relative
.html
links that may not resolve when certain features are not turned on... Pointing the user to a 404 page :(There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably a problem for another time, but these methods are deprecated anyway.