-
Notifications
You must be signed in to change notification settings - Fork 891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more specific error RequestIgnored
#3481
base: master
Are you sure you want to change the base?
Conversation
/// | ||
/// See [`InnerSizeWriter::request_inner_size`] for details. | ||
#[derive(Debug, Clone)] // Explicitly not other traits, in case we want to extend it in the future | ||
pub struct RequestIgnored { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kchibisov asked in #3067 (comment):
What's the reason this error is here and not on the
window
for example?
Because it's specific to InnerSizeWriter
, which is also in this module.
ae94840
to
2443baa
Compare
2443baa
to
ac0f918
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not really specific to this particular situation, sometimes it happens on X11 when setting something, e.g. locking.
In general we should have something like
error WindowError {
NotSupported,
RequestIgnored,
// etc...
}
We can leave it for 0.31, given that the a lot of weird hack like this one will be gone and it'll be more clear what to put into errors, once folks look into what their backends can do.
Split out from #3067.
CHANGELOG.md
if knowledge of this change could be valuable to users