Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use default-features, not default_features #3746

Merged
merged 1 commit into from
Jun 22, 2024
Merged

Use default-features, not default_features #3746

merged 1 commit into from
Jun 22, 2024

Conversation

waywardmonkeys
Copy link
Contributor

The latter syntax is deprecated and will be removed in Rust 2024 edition. This also generates a warning with current versions of Rust.

  • Tested on all platforms changed
  • Added an entry to the changelog module if knowledge of this change could be valuable to users
  • Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
  • Created or updated an example program if it would help users understand this functionality
  • Updated feature matrix, if new features were added or implemented

@waywardmonkeys
Use default-features, not default_features
2f394c0 
The latter syntax is deprecated and will be removed in Rust
2024 edition. This also generates a warning with current
versions of Rust.
@joshka joshka mentioned this pull request Jun 22, 2024
Closed
madsmtm
madsmtm approved these changes Jun 22, 2024
View reviewed changes
Copy link
Member

@madsmtm madsmtm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@madsmtm madsmtm merged commit c6c4395 into rust-windowing:master Jun 22, 2024
53 checks passed
@waywardmonkeys waywardmonkeys deleted the use-default-dash-features-not-underscore branch June 22, 2024 10:03
kchibisov pushed a commit that referenced this pull request Jul 16, 2024
@waywardmonkeys @kchibisov
Use default-features, not default_features (#3746)
4ebe217 
The latter syntax is deprecated and will be removed in Rust
2024 edition. This also generates a warning with current
versions of Rust.
kchibisov pushed a commit that referenced this pull request Jul 16, 2024
@waywardmonkeys @kchibisov
Use default-features, not default_features (#3746)
6abfef1 
The latter syntax is deprecated and will be removed in Rust
2024 edition. This also generates a warning with current
versions of Rust.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madsmtm madsmtm madsmtm approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@waywardmonkeys @madsmtm