Upgrade to smithay-client-toolkit 0.4 #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elinorbgr
suggested changes
Oct 9, 2018
| display: Arc::downgrade(&my_display), | ||
| pending_wakeup: Arc::downgrade(&my_pending_wakeup), | ||
| }, | ||
| }.receive(event, registry) |
There was a problem hiding this comment.
Can't the SeatManager be built once and then captured by the closure? This would reduce the number of clone().
| @@ -93,7 +92,7 @@ impl EventsLoopProxy { | |||
| // Update the `EventsLoop`'s `pending_wakeup` flag. | |||
| wakeup.store(true, Ordering::Relaxed); | |||
| // Cause the `EventsLoop` to break from `dispatch` if it is currently blocked. | |||
| let _ = display.sync(); | |||
| let _ = display.sync(|callback| {callback.implement(|_, _| {}, ())}); | |||
There was a problem hiding this comment.
I think the { .. } braces are not needed here.
| keyboard: None, | ||
| touch: None, | ||
| events_loop_proxy: self.events_loop_proxy.clone(), | ||
| })); |
There was a problem hiding this comment.
I don't understand the need to put the SeatData into an Arc<Mutex<_>>, given the arc is never cloned... ?
|
For the record, here is how alacritty looks like in weston with the new decorations:
|
elinorbgr
approved these changes
Oct 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG.mdif knowledge of this change could be valuable to users (Just about the decorations change)Upgrades to smithay-client-toolkit to version 4.0, biggest changes are
Now uses wayland 0.21 (doesn't use pure rust implementation because of c lib dependency that can hopefully be removed in the future)
Better 'ConceptFrame' for decorations which looks more visual appealing then 'BasicFrame'
Window titles will now be displayed in the header of the window
Fix wayland key repetition when keyboard loses focus
Fixes #657