Fix incorrect keycodes when using a non-US keyboard layout.

[Toqozz]

This commit fixes the issue described in #752, and uses the advised
method to fix it.

I'm relatively new to contributing and Rust (this is my first real contribution), and I'm sure my lack of experience is shining through here. Regardless, I hope that this PR fixes/assists in fixing the issue adequately!

• Tested on all platforms changed
• Added an entry to CHANGELOG.md if knowledge of this change could be valuable to users
• Updated documentation to reflect any user-facing changes, including notes of platform-specific behavior
• Created an example program if it would help users understand this functionality

[francesca64]

Sorry for the delay! I was on a business trip in Portland for the past week.

Thanks so much for this PR! From testing it, things work great, so the review just addresses code structure and style.

[Toqozz]

Thanks for the in-depth reply! I'll get to work on these issues now.

[Toqozz]

I've applied changes which (I believe) resolve most of what we've talked about here. There were some minor details that I was uncertain about (i.e. where to put get_scancode()), but these should be able to be easily resolved.

I was quite busy last week -- hence the delay -- but I should be able to resolve anything more quite quickly, so please let me know.

Thanks :)

[chrisduerr]

I just wanted to chime in and say that I've been using Alacritty with your winit branch for a while (on macOS) and it seems to be working great, haven't run into any issues.

[chrisduerr]

I don't think the remaining two 'TODO's are relevant for this PR so it might be a bit misleading to keep them in. Build also is just failing because there's a merge conflict in the CHANGELOG file.

Is there anything left to be done other than fixing the merge conflict? The functionality seems good to go and it would be a shame to forget about a QoL change like this.

[Toqozz]

What are the remaining two TODO's that you refer to? Did I miss something?

I would definitely still like to push this; things can be very annoying/confusing for non-qwerty users without it. I might even consider it crucial, since so many projects rely on winit.

[chrisduerr]

@Toqozz I'm talking about the list in the original comment of this PR. This is part of winit's PR template, but unfortunately if you look at the list of PRs, it shows up as '2 of 4' tasks done. So that can easily confuse maintainers to think there's still progress the author needs to complete.

[francesca64]

Sorry for the delay! Thanks so much for this great PR!