Use a docker container for generating keysyms #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
pentamassiv
approved these changes
Oct 22, 2023
|
I'm not opposed to the idea. Is |
i509VCB
reviewed
Oct 23, 2023
Previously, keysyms were just generated on the host operating system. This means that the keysyms that are generated varies from system to system, which is just bad form. This commit makes it so the keysyms are generated inside of a Docker container, which should make the process much more reproducible. Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
Signed-off-by: John Nunley <dev@notgull.net>
notgull
force-pushed
the
notgull/gen-keysyms
branch
from
569c7b0
to
a25b5f3
Compare
Signed-off-by: John Nunley <dev@notgull.net>
i509VCB
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, keysyms were just generated on the host operating system. This means that the keysyms that are generated varies from system to system, which is just bad form. This commit makes it so the keysyms are generated inside of a Docker container, which should make the process much more reproducible.