New API and XCB-1.14 support #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Simple structures that have the same memory layout than C are translated in
Rust directly (e.g. points etc.)
- More complex structures wrap a slice of raw data and provide accessor methods
(`Debug` will still print all the members)
- The masks use the `bitflags` crate macro
- The enums are enums!
- The unions are also enums, but they carry data
- The Xids (handles to windows, pixmaps etc.) are type-safe implementations of
the `Xid` trait, not just integers like with `0.x` versions.
- The requests are structures that serialize themselves when passed to the
`Connection`.
- Each request has two type of cookie, for checked and unchecked requests.
This allows type safe reply fetching and error checking
- The protocol and each extension provide an `Event` and an `Error` enum,
which are unified by the core library.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to provide a safe and sound Rust API for XCB.
Along the way, I will also drop the FFI bindings and implement the extensions code directly in Rust. (
rust-xcbwill no longer link against the C extensions dynamic libraries)Finally, the bindings are targeting the last version of the protocol: 1.14.
If I manage to get everything right, this will be
rust-xcb v1.0.0Do not hesitate to comment on the new API!
EDIT:
To get a grasp on the new API, the up-to-date crate documentation of this PR is automatically deployed here.