Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverb example rans into error with symphonia vorbis decoder #516

Closed
dvdsk opened this issue Oct 11, 2023 · 3 comments
Closed

Reverb example rans into error with symphonia vorbis decoder #516

dvdsk opened this issue Oct 11, 2023 · 3 comments

Comments

@dvdsk
Copy link
Collaborator

dvdsk commented Oct 11, 2023 •
edited
Loading

Probably belongs upstream in symphonia, ran into it testing #513.

seems like assets/music.ogg breaks the decoder.

Needed it documented somewhere so here it is. Reproducible on master branch with:

cargo r --example reverb --features symphonia-all
@dvdsk dvdsk changed the title Reverb example does not work with symphonia decoder Reverb example rans into error with symphonia decoder Oct 11, 2023
@dvdsk dvdsk changed the title Reverb example rans into error with symphonia decoder Reverb example rans into error with symphonia vorbis decoder Oct 11, 2023
@est31
Copy link
Member

est31 commented Oct 12, 2023

It's not hard to test if the culprit is symphonia: symphonia probably also has examples in their own repo. And if not, there is probably some symphonia user one could try.

@dvdsk dvdsk mentioned this issue Oct 12, 2023
Closed
@dvdsk
Copy link
Collaborator Author

dvdsk commented Oct 12, 2023

replicated upstream, moving this issue there.

see: pdeljanov/Symphonia#235

@dvdsk dvdsk closed this as completed Oct 12, 2023
@dvdsk
Copy link
Collaborator Author

dvdsk commented Jan 16, 2024

Issue is on this side, I'm working on it. Expect a PR sometime this week.

@dvdsk dvdsk reopened this Jan 16, 2024
@dvdsk dvdsk mentioned this issue Jan 18, 2024
Open
@dvdsk dvdsk closed this as completed Mar 24, 2024
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@est31 @dvdsk