Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dual audio transmission support #2981

Merged
merged 45 commits into from
Feb 8, 2023

Conversation

Kingtous
Copy link
Contributor

@Kingtous Kingtous commented Jan 29, 2023

related: #188

This PR is working on make dual audio transmission possible.

  • multi-instance audio service for dual audio transmission.
  • add dual transmission protocol.
  • fit for audio playing on both of host and server side.
  • tested on the cases below
    • Windows ---(controls)--> macOS
    • [-] [Working on] macOS ---(controls)--> Linux, loop back is not working yet
    • Linux ---(controls)--> macOS
  • add ui selection
    • sciter
    • flutter

This PR adds an option to enable dual audio transmission now. After switching to dual way of audio transmission, the input device will automatically set to the default speaker.

image

@test2a
Copy link

test2a commented Jan 29, 2023

So excited about this.....

Could this by any chance be modified to have video as well?

We can imagine like have a floating video widget showing your own and other side cameras...

@rustdesk
Copy link
Owner

So excited about this.....

Could this by any chance be modified to have video as well?

We can imagine like have a floating video widget showing your own and other side cameras...

no for short term

@Kingtous Kingtous changed the title WIP: dual audio transmission support feat: dual audio transmission support Jan 30, 2023
@Kingtous Kingtous marked this pull request as ready for review January 30, 2023 16:01
@Kingtous Kingtous marked this pull request as draft January 30, 2023 16:02
@Kingtous Kingtous marked this pull request as ready for review January 31, 2023 05:51
@Kingtous Kingtous marked this pull request as draft February 4, 2023 07:53
@Kingtous Kingtous force-pushed the feat/dual_audio_transmission branch 4 times, most recently from 5478141 to 011a94b Compare February 7, 2023 03:01
@Kingtous Kingtous marked this pull request as ready for review February 7, 2023 12:39
@rustdesk rustdesk merged commit 563225e into rustdesk:master Feb 8, 2023
@rustdesk
Copy link
Owner

rustdesk commented Feb 8, 2023

@test2a please test and feedback.

@test2a
Copy link

test2a commented Feb 8, 2023

@rustdesk nightly seems to be 4 hours old so should i download that or wait for new build?

@rustdesk
Copy link
Owner

rustdesk commented Feb 8, 2023

Thanks, it will be ready tommorrow.

@rustdesk
Copy link
Owner

rustdesk commented Feb 8, 2023

I can trigger it now, will be ready soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants