refactor dialog

[fufesou]

Mainly move dialogs from mobile path to common path.

[rustdesk]

@grummbeer do you have any idea about this dialog design which is for login to headless linux? Different from normal login, remote linux user/password is required for headless linux. I still think current dialog does explain clearly, the users can be confused by the additonal user name and password.

[rustdesk]

[grummbeer]

Let me try it first. How it feels and how it behave on (wrong) input.

I still think current dialog does explain clearly,

sorry, which?

the users can be confused by the additonal user name and password.

On the first glace, the message from toolip could placed directly obove the system login to avoid question marks. And below that, a heading for rustdesk password, even the placeholder already says so.

[grummbeer]

rustdesk/flutter/lib/common/widgets/dialog.dart

Line 544 in 9ec0b4b

usernameController == null || usernameController == null

both sides are the same

[rustdesk]

rustdesk/flutter/lib/common/widgets/dialog.dart

Line 544 in 9ec0b4b

usernameController == null || usernameController == null

both sides are the same

@fufesou

[rustdesk]

Let me try it first. How it feels and how it behave on (wrong) input.

I still think current dialog does explain clearly,

Sorry, i meant the new dialog above.

[rustdesk]

On the first glace, the message from toolip could placed directly obove the system login to avoid question marks.

Yes, @fufesou place it under title directly with smaller smaller light font, and change title to original one (before this PR). You even do not put a big question mark there, no guys know moving mouse there to show a tooltip.

[rustdesk]

and this seperator is not eye-catching enough, when I say put a seperator there, you should have some thinking also, not just for finishing an assigned job.

[grummbeer]

According to material https://m3.material.io/components/dialogs/guidelines#fb75c64c-81c1-45ea-b97b-eb0bcb4c5dc9

The headline should smaller and a kind of heading/description goes to both sections. Section 1. Login to system, section 2. Login to rustdesk.

[rustdesk]

Section 1. Login to system, section 2. Login to rustdesk.

Yes, @fufesou

[rustdesk]

Seperator line can be remove if so, I think, with heading (and its padding).

[grummbeer]

Seperator line can be remove if so, I think.

yes separation made by heading.

[grummbeer]

sorry if this is a stupid question but …

rustdesk/flutter/lib/common/widgets/dialog.dart

Lines 499 to 509 in 12a5a7c

	final username = usernameController?.text.trim() ?? '';
	final password = passwordController?.text.trim() ?? '';
	final peerPassword = peerPasswordController?.text.trim() ?? '';
	if (peerPasswordController != null && peerPassword.isEmpty) return;
	gFFI.login(
	// username,
	// password,
	id,
	peerPassword,
	remember,
	);

final username and final password not used due commented out in login() arguments.

1. What happen with them on submit?

2. Can you clarify the situation with a comment? or similar
   It is irritating when stumple upon such situations because it is not clear what is intended. Just a forgotten test? Something unfinished? Wanted as hint for later work? Can it be saftly removed? Or going the save way and leaveing it untouched to prevent the author from being pissed?

[fufesou]

final username and final password not used due commented out in login() arguments.

They should be sent to the controlled side. These variables are keet here for the near future work.

[fufesou]

Thanks for your reminder, I'll add some comments.

[grummbeer]

Thank you for the clarification!