Fix remote home button in file transfer #6093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
rustdesk
reviewed
Oct 19, 2023
flutter/lib/models/file_model.dart
Outdated
| final homeDir = ( await bind.sessionGetPeerOption( | ||
| sessionId: sessionId, name: "remote_home_dir")); | ||
|
|
||
| if (homeDir.isEmpty){ |
rustdesk
reviewed
Oct 19, 2023
flutter/lib/models/file_model.dart
Outdated
| if (homeDir.isEmpty){ | ||
| bind.sessionPeerOption( | ||
| sessionId: sessionId, name: "remote_home_dir", value: fd.path); | ||
| } |
There was a problem hiding this comment.
Do we really need store it as peer option? it will write disk and pollute peer options.
I could not find any direct implementation for the remote home directory yet but since the home path is correct in the first connection we can just store it according to the session ID and fetch it whenever needed.
There was a problem hiding this comment.
Ok, I will try to find a better way to get home directory. Or do you mean to store it somewhere else?
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
|
New changes:
Tested win, android, linux as remote side. Remote button is working the same as the video above. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #3508 (comment)
The original issue of #3508 has been already fixed (confirmed by OP and me).
Storing and fetching remote home directory for remote home button.Setting the directory as empty is opening home directory.
Rest implementation is unchanged. Local remote home button is working the same as before.
Screen.Recording.2023-10-19.at.4.17.04.AM.mov