Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat connect to peer on another server #6206

Closed

Conversation

sahilyeole
Copy link
Contributor

@sahilyeole sahilyeole commented Oct 28, 2023

Still working

#6198 (comment)
Currently, I'm able to connect a peer on the public server while the control side is connected to a private server.
Support for public -> private in progress.

Ex: 143242314@164.432.413: 21116?key=32432432Efdsf34 or 143242314@public

cc.mp4

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@sahilyeole sahilyeole marked this pull request as draft October 28, 2023 00:05
@sahilyeole
Copy link
Contributor Author

sahilyeole commented Oct 28, 2023

@rustdesk How can I know which public server the peer is connected to?
Currently, I have hardcoded it just for testing.
Or else I can loop and try every public server available when user provides @public.


Also with current implementation, I'm getting the unencrypted connection. How can I encrypt it?

Screenshot_20231028_053044

@rustdesk
Copy link
Owner

that is you need to figure out

@rustdesk
Copy link
Owner

public

You need to take care of this case https://rustdesk.com/docs/en/self-host/client-configuration/hardcode-settings/

@rustdesk
Copy link
Owner

No need to take care of multiple public servers, just use the first one, in the future we will use only one.

@sahilyeole
Copy link
Contributor Author

No need to take care of multiple public servers, just use the first one, in the future we will use only one.

Ok so I'm currently using rs-ny.rustdesk.com:21116 server for @public. Is that enough?

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@sahilyeole
Copy link
Contributor Author

sahilyeole commented Oct 29, 2023

I have added support to get the private server key from the text field but I'm getting this error on connecting:

Screenshot 2023-10-29 at 5 15 03 AM

as connection to private servers requires login credentials of the user allowed on that server.

So I can try to support this text field expression:
Ex: 143242314@164.432.413:21116?key="32432432Efdsf34"?username="admin"?password="admin1234"
and authenticate the user for that server only for this particular connection.

Also, according to this, I think adding user credentials for the text field expression might be good. #6198 (comment)

We'd need to find a way of making it impossible to copy the key, or of making this possible only if the Rustdesk user is logged in. Otherwise, the key could spread and my server become public...

Should we try this?

@rustdesk
Copy link
Owner

No need to take care of multiple public servers, just use the first one, in the future we will use only one.

Ok so I'm currently using rs-ny.rustdesk.com:21116 server for @public. Is that enough?

Can not be hard coded, it may change in the future.

@rustdesk
Copy link
Owner

Should we try this?

No

@rustdesk
Copy link
Owner

as connection to private servers requires login credentials of the user allowed on that server.

Expected, no need to consider for now.

@rustdesk
Copy link
Owner

rustdesk commented Oct 30, 2023

Also make sure 143242314@164.432.413:21116?key=32432432Efdsf34 works for uri, e.g. rustdesk://143242314@164.432.413:21116?key=32432432Efdsf34. and correctly saved in recent sessions

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@sahilyeole
Copy link
Contributor Author

  • Used RENDEZVOUS_SERVERS to get public server
  • URL connection done on macos. Windows & linux yet to check
  • Private -> public still working on the encryption part

@rustdesk rustdesk closed this Oct 31, 2023
@rustdesk
Copy link
Owner

rustdesk commented Oct 31, 2023

I will take over this issue. Please do the others

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants