Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: wayland clipboard support #6586

Merged
merged 4 commits into from Dec 1, 2023

Conversation

sahilyeole
Copy link
Contributor

@sahilyeole sahilyeole commented Dec 1, 2023

Fixes: #3455

Using arboard's wayland-data-control feature.
Also, set WAYLAND_DISPLAY env.
More details: #5900

Tested: Ubuntu (gnome+kde), kubuntu.
For some reason my github actions is failing arch linux and fedora package (even without the changes of this PR), so I couldn't test those.
But it should work on other distros too since env has been correctly set.

wl_clipboard.mp4

sahilyeole and others added 4 commits December 1, 2023 05:11
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@rustdesk rustdesk merged commit 56c176a into rustdesk:master Dec 1, 2023
14 checks passed
@rustdesk
Copy link
Owner

rustdesk commented Dec 1, 2023

The nightly build will be ready soon, please test arch, fedora, flatpak then.

@sahilyeole
Copy link
Contributor Author

sahilyeole commented Dec 1, 2023

It failed here too.
I've ran CI without my PR changes it was also failing to build arch package. I tried clearing cache too.
https://github.com/sahilyeole/rustdesk/actions/runs/7060930792/job/19222446715

@rustdesk
Copy link
Owner

rustdesk commented Dec 1, 2023

It seems upstream pkg server has some issue. Let's wait for fix and test later.

@rustdesk
Copy link
Owner

rustdesk commented Dec 1, 2023

Let's do #5949

@sahilyeole
Copy link
Contributor Author

Yes, I have completed remote desktop portal pipewire code for #5949
master...sahilyeole:rustdesk:feat/wayland_rdp
Now working on using it for input capture.

@rustdesk
Copy link
Owner

rustdesk commented Dec 1, 2023

👍

sahilyeole added a commit to sahilyeole/rustdesk that referenced this pull request Dec 2, 2023
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@sahilyeole
Copy link
Contributor Author

Tested arch (gnome + kde), fedora.
Clipboard is working as expected.

@rustdesk
Copy link
Owner

rustdesk commented Dec 5, 2023

👍

rustdesk pushed a commit that referenced this pull request Dec 19, 2023
* autogen portal code

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* use remote desktop portal

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* remove clipboard portal in favour of #6586

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* remove clipboard portal

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* use select_devices for input capture

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* remove embedded cursor code as not being used | return session path for input capture

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* setup rdp input

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* remove simulate example

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* setup rdp input raw key events + mouse movements

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* fix rdp raw key input

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* refact rdp raw key inpuy & fix right meta key

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* refact and support rdp layout mode key input

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* support rdp mouse clicks

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* support rdp mouse scroll

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* support rdp key sequence input

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* use rdp input only when uinput is not available

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* combine rdp input and get_capturables into a single rdp request

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* rdp fix build

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* rdp fix build

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* fix rdp caps lock

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* format pipewire.rs

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* format rdp_input.rs

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* revert #6628 as rdp request state is now managed (better solution)

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* fix rdp crash on arch kde

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* rdp_input.rs improvements

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* refact request_remote_desktop

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* improve unwraps

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* remove unwraps

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

* use session references instead of clones

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>

---------

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shared Clipboard not Functioning with Wayland
2 participants