Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix, windows try kill flutter main window process only when --server's ipc is occupied #8086

Merged
merged 1 commit into from
May 18, 2024

Conversation

21pages
Copy link
Collaborator

@21pages 21pages commented May 18, 2024

#8077

It can't be reproduced, so I make special exes to simulate it.

Test step:

  1. Make a special exe that --server will delay start ipc so that main window process have enough time to occupy the ipc, and install the exe.
  2. If main window occupy the ipc, it'll receive the close message from --service and call std::process::exit, If I change the multi window plugin and make it always prevent close, std::process::exit still work, in order to reproduce the occupying, make a special exe that remove the line std::process::exit, so that the main window can't be killed by --service. So this pr fix the condition that std::process::exit not work.
    std::process::exit(0);
  3. Kill the --server process and start the special main window process right now.
  4. If the installed exe is based on master, --server will be restarted in a loop; If the installed exe is based on pr, --server will kill the main window process when it finds that its ipc is occupied.
based_on_master.mp4
based_on_pr.mp4

…s ipc is

occupied

Signed-off-by: 21pages <pages21@163.com>
@rustdesk rustdesk merged commit d3eaa66 into rustdesk:master May 18, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants