Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fall back to precompiled API snippet if gen_api.erl fails #238

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Fall back to precompiled API snippet if gen_api.erl fails #238

merged 3 commits into from
Oct 16, 2019

Conversation

filmor
Copy link
Member

@filmor filmor commented Sep 18, 2019

Should fix #236 and similar issues.

@filmor
Copy link
Member Author

filmor commented Sep 18, 2019

Should be rebased on #233.

@filmor
Copy link
Member Author

filmor commented Oct 9, 2019

@scrogson @hansihe Do you need help in the maintenance? There are quite a few PRs pending and in particular the brokenness of docs.rs right now makes it a bit tricky to use the library.

scrogson
scrogson approved these changes Oct 13, 2019
View reviewed changes
Copy link
Member

@scrogson scrogson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a good solution 👍

@filmor filmor merged commit dc37b56 into rusterlium:master Oct 16, 2019
@filmor filmor deleted the precompiled-nif-api branch October 16, 2019 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrogson scrogson scrogson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs.rs broken
2 participants
@filmor @scrogson