Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a simple Debug impl for Error #248

Merged
merged 3 commits into from
Oct 16, 2019
Merged

Add a simple Debug impl for Error #248

merged 3 commits into from
Oct 16, 2019

Conversation

filmor
Copy link
Member

@filmor filmor commented Oct 15, 2019

No description provided.

@filmor filmor mentioned this pull request Oct 16, 2019
Merged
@filmor filmor requested a review from scrogson October 16, 2019 21:59
scrogson
scrogson requested changes Oct 16, 2019
View reviewed changes
Copy link
Member

@scrogson scrogson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase on master and remove the ok().expect(...) from the atom module?

@filmor
Copy link
Member Author

filmor commented Oct 16, 2019

Done.

@filmor filmor merged commit 9624f53 into rusterlium:master Oct 16, 2019
@filmor filmor deleted the add-error-debug branch October 16, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrogson scrogson scrogson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@filmor @scrogson