Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make OwnedBinary NifReturnable #289

Merged
merged 1 commit into from
Dec 9, 2019
Merged

Make OwnedBinary NifReturnable #289

merged 1 commit into from
Dec 9, 2019

Conversation

szlend
Copy link
Contributor

@szlend szlend commented Nov 28, 2019

This implements #286 by allowing a way to return OwnedBinary without explicitly converting it into a Binary. I also changed the generic signature of NifReturnable for Result<T, crate::error::Error> so it works with all NifReturnable types.

scrogson
scrogson approved these changes Nov 29, 2019
View reviewed changes
Copy link
Member

@scrogson scrogson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scrogson scrogson merged commit 96e6721 into rusterlium:master Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrogson scrogson scrogson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szlend @scrogson