Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Remove superfluous use statements from proc-macros (#240)" #298

Merged
merged 1 commit into from
Jan 28, 2020
Merged

Revert "Remove superfluous use statements from proc-macros (#240)" #298

merged 1 commit into from
Jan 28, 2020

Conversation

evnu
Copy link
Member

@evnu evnu commented Jan 28, 2020

This reverts commit afda9b8. The use statements are needed when a user did not already use rustler::Encoder. A user would have to manually add the use statement, which is cumbersome.

@evnu evnu requested a review from scrogson January 28, 2020 08:32
@filmor filmor merged commit 6511e87 into rusterlium:master Jan 28, 2020
@evnu evnu deleted the revert-removing-encoder-from-codegen branch January 29, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scrogson scrogson scrogson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@evnu @scrogson @filmor