Remove OwnedBinary's release flag #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JayKickliter
force-pushed
the
jsk/remove-unnecessary-flag
branch
from
4b052b4
to
dc3cc6a
Compare
|
My natural reaction would be to fix those unrelated clippy lints in another commit, but I'll hold off to keep the current diff clean. |
JayKickliter
force-pushed
the
jsk/remove-unnecessary-flag
branch
from
dc3cc6a
to
0d9e798
Compare
|
@JayKickliter Thanks for the PR! I fixed the clippy lints on master. Could you rebase please? |
filmor
approved these changes
Sep 7, 2020
filmor
reviewed
Sep 7, 2020
release signals to OwnedBinary's Drop implementation whether or not call enif_release_binary(). the only place that changes release from true to false is in Binary::from_owned(). We can therefore remove the release flag altogether by simply preventing drop() in Binary::from_owned().
JayKickliter
force-pushed
the
jsk/remove-unnecessary-flag
branch
from
0d9e798
to
8d4e55a
Compare
|
Perfect, thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
releasesignals toOwnedBinary'sDropimplementation whether or not callenif_release_binary(). The only place that changesreleasefromtruetofalseis inBinary::from_owned(). We can therefore remove the release flag altogether by simply preventingdrop()inBinary::from_owned().