Fix clippy lints #346
Merged
Fix clippy lints #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prefer collect() over from_iter(): clippy::from-iter-instead-of-collect * Prefer `From` over `Into`: clippy::from-over-into * Avoid nested match: clippy::collapsible-match * Avoid unnecessary wraps: clippy::unnecessary-wraps * Obey naming convention of `as_`: clippy::wrong-self-convention
evnu
commented
Jan 6, 2021
| @@ -16,14 +16,14 @@ pub use crate::wrapper::{ | |||
| pub use rustler_sys::{TWinDynNifCallbacks, WIN_DYN_NIF_CALLBACKS}; | |||
|
|
|||
| pub unsafe trait NifReturnable { | |||
| unsafe fn as_returned(self, env: Env) -> NifReturned; | |||
There was a problem hiding this comment.
Clippy advises that as_ should take &self or &mut self (see here). As we want to take ownership here (or am I mistaken?), the function should be prefixed with into_ instead.
There was a problem hiding this comment.
This sounds right to me 👍
codegen_runtime is pub but hidden, so I wouldn't see this as a breaking change.
There was a problem hiding this comment.
Agreed, codegen_runtime is public because it is used by our macros, but is not a documented or stable API outside of that.
filmor
approved these changes
Jan 7, 2021
hansihe
approved these changes
Jan 7, 2021
| @@ -16,14 +16,14 @@ pub use crate::wrapper::{ | |||
| pub use rustler_sys::{TWinDynNifCallbacks, WIN_DYN_NIF_CALLBACKS}; | |||
|
|
|||
| pub unsafe trait NifReturnable { | |||
| unsafe fn as_returned(self, env: Env) -> NifReturned; | |||
There was a problem hiding this comment.
Agreed, codegen_runtime is public because it is used by our macros, but is not a documented or stable API outside of that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The periodic CI run from #344 found some clippy lints.
FromoverInto: clippy::from-over-intoas_: clippy::wrong-self-convention