Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying a channel for the system rustc #347

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

jflatow
Copy link
Contributor

@jflatow jflatow commented Feb 1, 2021

This is useful if you want to use e.g. {:system, "+nightly"}

@evnu
Copy link
Member

evnu commented Aug 2, 2021

The format "+nightly" might come as a surprise to users: If they use something like {:system, "nightly"}, cargo will think that the channel is actually an unknown command. We should either document the expected format with + or use atoms and translate ({:system, :nightly}). What do you think? Documenting the required + is probably the simplest thing to do here.

@jflatow
Copy link
Contributor Author

jflatow commented Aug 2, 2021

Added some clarification, let me know what you think.

@evnu
Copy link
Member

evnu commented Aug 3, 2021

I like it, thanks!

@evnu
Copy link
Member

evnu commented Aug 3, 2021

@jflatow Can you fix the format error?

@jflatow
Copy link
Contributor Author

jflatow commented Aug 3, 2021

Should be passing CI now, though I don't see the checks running at all again

@evnu
Copy link
Member

evnu commented Aug 4, 2021

Should be passing CI now, though I don't see the checks running at all again

Seems that I need to run that explicitly. CI went through, thank you!

@evnu evnu merged commit 662e36b into rusterlium:master Aug 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants