Fix f32 type conversion to be safe #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Virviil
force-pushed
the
f32_decoding_bug
branch
from
08dfea9
to
e210aa4
Compare
evnu
reviewed
Mar 29, 2021
evnu
requested changes
Mar 29, 2021
|
I'm not sure why |
evnu
requested changes
Mar 30, 2021
Virviil
force-pushed
the
f32_decoding_bug
branch
from
b740ba7
to
5505698
Compare
|
Thanks again @Virviil ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Decoding
f32is made usingenif_get_double, which obviously consumes values bigger thanf32:MAX.Then,
ret as f32not limiting the value by it's max, either turn it to bef32:INFINITY. This leads to confusions and even nif panics.